A re-roll of this trivial clean-up series, now with 2x more patches for missed cases pointed-out by Junio at https://lore.kernel.org/git/xmqqsfv5b6u6.fsf@gitster.g/ Ævar Arnfjörð Bjarmason (4): pack-objects: use BUG(...) not die("BUG: ...") strbuf.h: use BUG(...) not die("BUG: ...") pathspec: use BUG(...) not die("BUG:%s:%d....", <file>, <line>) object.h: use BUG(...) no die("BUG: ...") in lookup_object_by_type() builtin/pack-objects.c | 2 +- object.c | 2 +- pathspec.h | 3 +-- strbuf.h | 2 +- tree-diff.c | 3 +-- 5 files changed, 5 insertions(+), 7 deletions(-) Range-diff against v1: 1: 2a17ed9f135 = 1: 4f39177a763 pack-objects: use BUG(...) not die("BUG: ...") 2: ab89fec50c3 = 2: 6740c5d0da8 strbuf.h: use BUG(...) not die("BUG: ...") -: ----------- > 3: 81e354fa3be pathspec: use BUG(...) not die("BUG:%s:%d....", <file>, <line>) -: ----------- > 4: aaf952a9ede object.h: use BUG(...) no die("BUG: ...") in lookup_object_by_type() -- 2.34.1.898.g5a552c2e5f0