On Sun, Dec 5, 2021 at 3:56 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Neeraj Singh <nksingh85@xxxxxxxxx> writes: > > > On Sun, Dec 05, 2021 at 10:23:08AM -0800, Junio C Hamano wrote: > >> "Neeraj Singh via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > >> > >> > /* > >> > * This object store is ephemeral, so there is no need to fsync. > >> > */ > >> > - int will_destroy; > >> > + unsigned int will_destroy : 1; > >> > >> <CANQDOddCC7+gGUy1VBxxwvN7ieP+N8mQhbxK2xx6ySqZc6U7-g@xxxxxxxxxxxxxx> > >> ? > >> > >> (https://github.com/git/git/pull/1076#discussion_r750645345) > > > > Thanks for noticing this! I also lost one other change > > while splitting this out: we are referencing > > the_repository from the refs code, but as of 34224e14d we > > should be picking it up from the ref_store. I'll submit > > an updated series as soon as it passes CI. > > No rush. > > Reviewers and other project participants would appreciate you more > if you took a deep breath, after seeing a CI success, and gave a > final re-reading of the patches with a critical pair of eyes, before > you send the updated series out. > > Thanks. Fair enough. Of course I didn't see your email before I resubmitted. Thanks for the feedback.
