Hi Junio, On Wed, 1 Dec 2021, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > This patch series' focus is entirely on Scalar, on choosing sensible > > defaults and offering a delightful user experience around working with > > monorepos, and not about changing any existing paradigms for contrib/. > > Sorry, but I am confused. > > The change to add "make &&" before testing scalar is a good change > that allows CI to work with "existing paradigm for contrib/" that is > "you need to build the top before doing anything in contrib/". > > But none of the contrib/ stuff is tested in the pedantic job, but if > I understand correctly, we start some (namely, scalar) stuff in it > tested there, deviating from existing practice. Is that intended? No, it was not intended. It was not even intended to integrate Scalar this tightly with Git's CI, but since you did not move along `js/scalar` into `next` for the past weeks, when no reviewer had anything to add to the actual code in `contrib/scalar/` nor were there any objections to integrate it, I made the mistake of assuming that you agreed with Ævar that such a tight integration into Git's CI was desired. However, I do not want to make the mistake again of assuming what your thoughts are, so let me ask you directly: from your perspective, what is stopping the inclusion of `js/scalar` into `next`? I am patiently and eagerly awaiting your answer, Dscho
