Re: [PATCH v3 0/3] vimdiff: new implementation with layout support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 30, 2021 at 3:43 PM Fernando Ramos <greenfoo@xxxxxx> wrote:
>   * Use "$" inside arithmetic expressions $((...))
>     NOTE: "shellcheck" issues a warning stating that "$" is not needed inside
>     arithmetic expressions.

Just a side note: I understand that [1] recommended adding the "$"
inside arithmetic expressions, but by chance I happened to be browsing
the history of CodingGuidelines and ran across 32b5fe7f0e
(CodingGuidelines: drop arithmetic expansion advice to use "$x",
2020-05-04) which dropped[2] the recommendation to use "$" inside the
expression. Anyhow, certainly not worth a re-roll.

By the way, since you've removed Bashisms, do you still need the
`#!/bin/bash` at the top of the script?

[1]: https://lore.kernel.org/git/CAJDDKr5KZK3wpox6FJPOL9koPr=k5+qTzZtPPFEmg4iZsvwoog@xxxxxxxxxxxxxx/
[2]: https://lore.kernel.org/git/20200504160709.GB12842@xxxxxxxxxxxxxxxxxxxxxxx/



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux