On 11/22/2021 1:41 PM, Jonathan Tan wrote: > The multi-pack index treats promisor packfiles (that is, packfiles that > have an accompanying .promisor file) the same as other packfiles. Remove > a section in the documentation that seems to indicate otherwise. > > Signed-off-by: Jonathan Tan <jonathantanmy@xxxxxxxxxx> > --- > Stolee, can you check if my understanding is correct? > > To my recollection, midx does not treat promisor packfiles specially, > and searching for "promisor" in midx.c seems to support that (the only > results are relating to selection of commits for midx bitmap creation). Yes, you are correct that the promisor packfiles are included in the multi-pack-index. > -- The partial clone feature records special "promisor" packs that > - may point to objects that are not stored locally, but available > - on request to a server. The multi-pack-index does not currently > - track these promisor packs. > - The intention of this paragraph was probably that the multi-pack-index file does not track the properties of a pack-file such as whether a .promisor or .keep file exists. I think one thought was to eventually let the multi-pack-index track those properties, but there wasn't much value in it. Deleting this paragraph is a suitable clarification. Thanks, -Stolee
