This topic improves the output we emit on ambiguous objects as noted in 3/3, and makes it translatable. See [3] for v3. The only changes since v3 are minor commit message improvements spotted while re-rolling this. I think revewers were happy with it in v3, but it fell through the cracks. 1. https://lore.kernel.org/git/cover-v3-0.3-00000000000-20211008T193041Z-avarab@xxxxxxxxx/ Ævar Arnfjörð Bjarmason (3): object-name: remove unreachable "unknown type" handling object-name: make ambiguous object output translatable object-name: show date for ambiguous tag objects object-name.c | 68 +++++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 61 insertions(+), 7 deletions(-) Range-diff against v3: 1: fb29e10ee35 ! 1: 2e7090c09f9 object-name: remove unreachable "unknown type" handling @@ Metadata ## Commit message ## object-name: remove unreachable "unknown type" handling - Remove the "unknown type" handling when displaying the ambiguous - object list. See [1] for the current output, and [1] for the commit - that added the "unknown type" handling. + Remove unreachable "unknown type" handling in the code that displays + the ambiguous object list. See [1] for the current output, and [1] for + the commit that added the "unknown type" handling. The reason this code wasn't reachable is because we're not passing in - OBJECT_INFO_ALLOW_UNKNOWN_TYPE, so we'll just die in sort_ambiguous() + OBJECT_INFO_ALLOW_UNKNOWN_TYPE, so we'll die in sort_ambiguous() before we get to show_ambiguous_object(): $ git rev-parse 8315 2: 587a5717e47 ! 2: 00d84faeb1d object-name: make ambiguous object output translatable @@ Commit message Change the output of show_ambiguous_object() added in [1] and last tweaked in [2] and the preceding commit to be more friendly to - translators. By being able to customize the "<SP><SP>%s\n" format - we're even ready for RTL languages, who'd presumably like to change - that to "%s<SP><SP>\n". + translators. + + By being able to customize the "<SP><SP>%s\n" format we're even ready + for RTL languages, who'd presumably like to change that to + "%s<SP><SP>\n". 1. 1ffa26c461 (get_short_sha1: list ambiguous objects on error, 2016-09-26) 3: 8bde4e174b7 = 3: 9d24bab635d object-name: show date for ambiguous tag objects -- 2.34.0.822.gc64b680fd55
