On Mon, Nov 22, 2021 at 4:21 PM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > > On Mon, Nov 22 2021, Han-Wen Nienhuys via GitGitGadget wrote: > > > Z=$ZERO_OID > > +TAB=' ' > > > > m=refs/heads/main > > n_dir=refs/heads/gu > > @@ -318,11 +319,12 @@ test_expect_success 'symref empty directory removal' ' > > cat >expect <<EOF > > $Z $A $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> 1117150200 +0000 Initial Creation > > $A $B $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> 1117150260 +0000 Switch > > -$B $A $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> 1117150860 +0000 > > +$B $A $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> 1117150860 +0000$TAB > > So preceding commits added a trailing tab, or was that always the case > with the alternate test utility? log_ref_write_fd() only writes \t into the log message if there is a non-empty message, and previously this was checking the log file directly. The test helper tweaked in one of the previous commits unconditionally prints a \t, which we now have to deal with. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado