Ævar Arnfjörð Bjarmason wrote: > Change the names used for the GitHub CI workflows to be short enough > to (mostly) fit in the pop-up tool-tips that GitHub shows in the > commit view. I.e. when mouse-clicking on the passing or failing > check-mark next to the commit subject. > > These names are seemingly truncated to 17-20 characters followed by > three dots ("..."). Since a "CI/PR / " prefix is added to them the job > names looked like this before (windows-test and vs-test jobs omitted): > > CI/PR / ci-config (p... > CI/PR / windows-buil... > CI/PR / vs-build (pu... > CI/PR / regular (lin... > CI/PR / regular (lin... > CI/PR / regular (os... > CI/PR / regular (os... > CI/PR / regular (lin... > CI/PR / regular (lin... > CI/PR / dockerized (... > CI/PR / dockerized (... > CI/PR / dockerized (... > CI/PR / static-anal... > CI/PR / sparse (pu... > CI/PR / documenta... > > By omitting the "/PR" from the top-level name, and pushing the > $jobname to the front we'll now instead get: > > CI / config (push) > CI / win build (push... > CI / win+VS build (... > CI / linux-clang (ub... > CI / linux-gcc (ubun... > CI / osx-clang (osx)... > CI / osx-gcc (osx) (... > CI / linux-gcc-defau... > CI / linux-leaks (ub... > CI / linux-musl (alp... > CI / Linux32 (daald/... > CI / pedantic (fedor... > CI / static-analysis... > CI / sparse (push)... > CI / documentation > > We then have no truncation in the expanded view. See [1] for how it > looked before, [2] for a currently visible CI run using this commit, > and [3] for the GitHub workflow syntax involved being changed here. > > Let's also use the existing "pool" field as before. It's occasionally > useful to know we're running on say ubuntu v.s. fedora. The "-latest" > suffix is useful to some[4], and since it's now at the end it doesn't > hurt readability in the short view compared to saying "ubuntu" or > "macos". > > 1. https://github.com/git/git/tree/master/ > 2. https://github.com/avar/git/tree/avar/ci-rm-travis-cleanup-ci-names-3 > 3. https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions > 3. https://lore.kernel.org/git/d9b07ca5-b58d-a535-d25b-85d7f12e6295@xxxxxxxxxx/ > > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> > --- > .github/workflows/main.yml | 10 +++++++++- > README.md | 2 +- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml > index 6ed6a9e8076..c7c10456572 100644 > --- a/.github/workflows/main.yml > +++ b/.github/workflows/main.yml > @@ -1,4 +1,4 @@ > -name: CI/PR > +name: CI > > on: [push, pull_request] > > @@ -7,6 +7,7 @@ env: > > jobs: > ci-config: > + name: config > runs-on: ubuntu-latest > outputs: > enabled: ${{ steps.check-ref.outputs.enabled }}${{ steps.skip-if-redundant.outputs.enabled }} > @@ -77,6 +78,7 @@ jobs: > } > > windows-build: > + name: win build > needs: ci-config > if: needs.ci-config.outputs.enabled == 'yes' > runs-on: windows-latest > @@ -97,6 +99,7 @@ jobs: > name: windows-artifacts > path: artifacts > windows-test: > + name: win test > runs-on: windows-latest > needs: [windows-build] > strategy: > @@ -127,6 +130,7 @@ jobs: > name: failed-tests-windows > path: ${{env.FAILED_TEST_ARTIFACTS}} > vs-build: > + name: win+VS build > needs: ci-config > if: needs.ci-config.outputs.enabled == 'yes' > env: > @@ -178,6 +182,7 @@ jobs: > name: vs-artifacts > path: artifacts > vs-test: > + name: win+VS test > runs-on: windows-latest > needs: vs-build > strategy: > @@ -210,6 +215,7 @@ jobs: > name: failed-tests-windows > path: ${{env.FAILED_TEST_ARTIFACTS}} > regular: > + name: ${{matrix.vector.jobname}} (${{matrix.vector.pool}}) > needs: ci-config > if: needs.ci-config.outputs.enabled == 'yes' > strategy: > @@ -251,6 +257,7 @@ jobs: > name: failed-tests-${{matrix.vector.jobname}} > path: ${{env.FAILED_TEST_ARTIFACTS}} > dockerized: > + name: ${{matrix.vector.jobname}} (${{matrix.vector.image}}) > needs: ci-config > if: needs.ci-config.outputs.enabled == 'yes' > strategy: > @@ -310,6 +317,7 @@ jobs: > run: ci/install-dependencies.sh > - run: make sparse > documentation: > + name: documentation > needs: ci-config > if: needs.ci-config.outputs.enabled == 'yes' > env: > diff --git a/README.md b/README.md > index eb8115e6b04..f6f43e78deb 100644 > --- a/README.md > +++ b/README.md > @@ -1,4 +1,4 @@ > -[![Build status](https://github.com/git/git/workflows/CI/PR/badge.svg)](https://github.com/git/git/actions?query=branch%3Amaster+event%3Apush) > +[![Build status](https://github.com/git/git/workflows/CI/badge.svg)](https://github.com/git/git/actions?query=branch%3Amaster+event%3Apush) > > Git - fast, scalable, distributed revision control system > ========================================================= > This addresses all of my earlier comments - looks good to me!