Re: [PATCH] Makefile: fix parallel build race

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ævar,

On Fri, 19 Nov 2021, Ævar Arnfjörð Bjarmason wrote:

> I think getting it working on non-Windows if we're going to keep it
> (which looks to be the case) would be very useful.

The idea to extend the CMake to more than just Windows is contrary to what
Junio said in
https://lore.kernel.org/git/xmqq1rmcm6md.fsf@xxxxxxxxxxxxxxxxxxxxxx/:

	Let's not worry about cross-platform and instead stick to Windows
	and nothing else for now to expedite the process.  As long as it
	is advertised as such, nobody would complain that it does not work
	on Linux or macOS.

If that is not enough to tone down opposing opinions (the opinion of the
Git maintainer is more important, after all, it's his maintenance burden
so he gets to decide), you can also look at this statement from
https://lore.kernel.org/git/xmqq8sikblv2.fsf@xxxxxxxxxxxxxxxxxxxxxx/:

	I already said that I feel that engineering burden to divert
	resources for CMake support would be unacceptably high.

The only reason we have CMake in addition to the Makefile (and the
autoconf-based) setup is that CMake makes it possible to build Git on
Windows in the development environment with which the majority of the
developers on Windows are familiar: Visual Studio.

If it weren't for those developers, for who it would be a ridiculous
suggestion to "just go download GNU make", we would not have the CMake
based build at all.

And I am still agreeing with what Junio further said in the second mail I
linked above:

	[...] it is unclear why it would be beneficial to slow our
	existing developers down by forcing them to become familiar with
	CMake.

So now we are discussing to extend the CMake build to allow Linux and
macOS developers to use it, to, for little to no benefit. We are very much
in the situation where we are slowed down by discussing something as
non-essential as extending our CMake support beyond Windows, while patches
that are provably much more beneficial to a lot more people are left
under-reviewed.

Even worse: reviewers who _could_ provide high-quality reviews for those
patches (which takes a lot of time and diligence), but are as much pressed
for time as I am and therefore have to choose wisely how to spend their
time, are _actively_ distracted from spending their time more wisely.

Can't we please focus on more relevant things again? Pretty please?

Ciao,
Johannes

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux