On Fri, Nov 19 2021, Bagas Sanjaya wrote: > On 18/11/21 17.50, Aleen via GitGitGadget wrote: >> +test_expect_success 'still output error with --empty when meeting empty files' ' >> + test_must_fail git am --empty=drop empty.patch 2>actual && >> + echo Patch format detection failed. >expected && >> + test_cmp expected actual >> +' > > Why isn't the echo string quoted? There's no need to quote the arguments given to echo in cases like these. It's not the same, i.e. it'll get N arguments on argv and not on, but it makes it easier to spot things that do need quoting, rather than over-quoting everything.
