On Wed, Nov 17, 2021 at 11:58:00PM -0800, Carlo Arenas wrote: > On Wed, Nov 17, 2021 at 9:34 PM Mike Hommey <mh@xxxxxxxxxxxx> wrote: > > On Wed, Nov 17, 2021 at 08:51:06PM -0800, Carlo Arenas wrote: > > > It is not in 2.34; only in the git for windows fork, but agree is > > > needed if you are building master with a newish mingw > > > > Err, I did mean 2.34.0.windows.1. My working workaround is to build with > > -D_POSIX_THREAD_SAFE_FUNCTIONS=200112L. > > that is strange, building main/2.34.0.windows.1 works for me both in a > mingw64 shell and the git for windows sdk, and the PR[1] worked as > well when applied to 2.34/master that uses a git for windows sdk for > building it and that would had failed without it as you reported. > > what version `pacman -q | grep pthread` of the winpthreads library do > you have?, anything else peculiar about your build environment that > you could think of? > > that define and the setting in git-compat-util.h should have > equivalent effect in your mingw headers; what does the relevant > (almost at the bottom, where the problematic functions are defined) > part of /mingw64/x86_64-w64-mingw32/include/time.h say? Oh my bad, I overlooked an important part of the build log: it was a mingw32 build, not minwg64. Mingw64 builds fine without -D_POSIX_THREAD_SAFE_FUNCTIONS=200112L. Mingw32 requires it (because the ifdefs are for mingw64) Mike
