Jonathan Tan <jonathantanmy@xxxxxxxxxx> writes: > I don't feel as confident about this patch as I do about the patches > that remove the global variables - as you said, some functions might use > the_repository to parse OIDs (or do other things). I think that part of > this patch should go into the next series you have planned (as you > describe in the original cover letter [1], when you make future > submodule commands be run in-process), so that they can be tested. > (Removing the global variables was more of a mechanical code change, so > it was easier to see what's going on by just looking at "before" and > "after".) Thanks! I think that thematically, this patch belongs in this series. But that is not worth leaving the code untested, so I will move this patch into my future series.
