"Robin Jarry" <robin@xxxxxxxx> writes: >> > + sigchain_push(SIGPIPE, SIG_IGN); >> > if (pack_lockfile) >> > unlink_or_warn(pack_lockfile); >> >> Shouldn't we start ignoring SIGPIPE here, not before we try to >> unlink the lockfile? > > I initially wanted to avoid getting SIGPIPE'd while printing a warning > if the lockfile cannot be unlinked. Maybe this means the repository > integrity is compromised and we are well beyond ensuring post-receive is > executed or not. I do not know git internals well enough to be sure. > > What do you think? I think that push/pop pair should surround the part that reports the status, as the proposed commit log message said. Thanks.
