On Sat, Nov 6, 2021 at 5:47 PM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > Stop having GET_OID_ONLY_TO_DIE imply GET_OID_QUIETLY in > get_oid_with_context_1(). > > The *_DIE flag was added in 33bd598c390 (sha1_name.c: teach lookup > context to get_sha1_with_context(), 2012-07-02), and then later > tweaked in 7243ffdd78d (get_sha1: avoid repeating ourselves via > ONLY_TO_DIE, 2016-09-26). > > Everything in that commit makes sense, but only for callers that > expect to fail in an initial call to get_oid_with_context_1(), e.g. as > "git show 0017" does via handle_revision_arg(), and then would like to > call get_oid_with_context_1() again via this > maybe_die_on_misspelt_object_name() function. > > In the subsequent commit we'll add a new caller that excepts to call > this only once, but who would still like to have all the error > messaging that GET_OID_ONLY_TO_DIE gives it, in addition to any > regular errors. s/excepts/expects/ > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
