Re: [PATCH v2] i18n: fix typos found during l10n for git 2.34.0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 4, 2021 at 12:26 AM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> Bagas Sanjaya <bagasdotme@xxxxxxxxx> writes:
>
> >> diff --git a/ref-filter.c b/ref-filter.c
> >> index 282cdad103..08a3f839c9 100644
> >> --- a/ref-filter.c
> >> +++ b/ref-filter.c
> >> @@ -1037,7 +1037,7 @@ int verify_ref_format(struct ref_format *format)
> >>                   format->quote_style == QUOTE_TCL) &&
> >>                   used_atom[at].atom_type == ATOM_RAW &&
> >>                   used_atom[at].u.raw_data.option == RAW_BARE)
> >> -                    die(_("--format=%.*s cannot be used with"
> >> +                    die(_("--format=%.*s cannot be used with "
> >>                            "--python, --shell, --tcl"), (int)(ep - sp - 2), sp + 2);
> >>              cp = ep + 1;
> >>
> >
> > Why not using \n?
>
> It is not quite clear to me why it should.
>
> Among the possible string that is (ep - sp - 2) bytes long (i.e.
> --python, --shell, --tcl, --raw), even with the longest, the
> resulting message would become
>
>     fatal: --format=--python cannot be used with
>     --python, --shell, --tcl.
>
> that is unusually short with such a newline in the middle.

In order to detect typos in new i18n messages added upstream in time,
a new CI workflow has been added in the "pot/CI" branch. See:

    https://github.com/git-l10n/git-po/blob/pot/CI/.github/workflows/git-pot.yml

This workflow will be triggered several times a day, and changes of
i18n messages will be saved as "YYYY-mm-dd.diff" in the following
branches:

* https://github.com/git-l10n/git-po/tree/pot/master
* https://github.com/git-l10n/git-po/tree/pot/next
* https://github.com/git-l10n/git-po/tree/pot/seen

L10n contributors can also refer to the "po/git.pot" file in the
"pot/master" branch to prepare translations in advance.

--
Jiang Xin



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux