Re: [PATCH] rebase -i: fix rewording with --committer-date-is-author-date

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Eric

On 02/11/2021 21:05, Eric Sunshine wrote:
On Tue, Nov 2, 2021 at 4:10 PM Phillip Wood via GitGitGadget
<gitgitgadget@xxxxxxxxx> wrote:
baf8ec8d3a (rebase -r: don't write .git/MERGE_MSG when
fast-forwarding, 2021-08-20) stopped reading the author script in
run_git_commit() when rewording a commit. This is normally safe
because "git commit --amend" preserves the authorship. However if the
user passes "--committer-date-is-author-date" then we need to read the
author date from the author script when rewording. Fix this regression
by tightening the check for when it is safe to skip reading the author
script.

Signed-off-by: Phillip Wood <phillip.wood@xxxxxxxxxxxxx>

Should this have a:

     Reported-by: Jonas Kittner <jonas.kittner@xxxxxxxxxxxxxxxxxx>

Yes it should and does locally but I forgot to push the updated version.

Thanks

Phillip

?





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux