On Mon, Nov 1, 2021 at 12:10 PM Ævar Arnfjörð Bjarmason
<avarab@xxxxxxxxx> wrote:
>
> We have over 50 uses of "isatty(1)" and "isatty(2)" in the codebase,
> only these two used the stdlib.h macros to refer to them.
>
> Let's change these for consistency, and because a subsequent commit's
> commit message outlines a recipe to change all of these for ad-hoc
> testing, not needing to match these with that ad-hoc regex will make
> things easier to explain.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
> ---
> builtin/bisect--helper.c | 2 +-
> builtin/bundle.c | 2 +-
> compat/mingw.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
> index 28a2e6a5750..1727cb051fb 100644
> --- a/builtin/bisect--helper.c
> +++ b/builtin/bisect--helper.c
> @@ -830,7 +830,7 @@ static int bisect_autostart(struct bisect_terms *terms)
> fprintf_ln(stderr, _("You need to start by \"git bisect "
> "start\"\n"));
>
> - if (!isatty(STDIN_FILENO))
> + if (!isatty(1))
STDIN_FILENO -> 0
Carlo
