On Mon, Nov 01, 2021 at 07:09:05PM +0000, Eric Wong wrote: > > Per exhibit a, what should we do in the situation where we discover unicode > > control characters in an email? > > > > 1. Warn and strip these chars out, because they are extremely unlikely to be > > doing anything legitimate in the context of a patch (unless someone is > > sending patches for docs actually written in RTL languages) > > 2. Warn and error out, refusing to produce an mbox > > 3. Just warn and produce an mbox anyway > > > > I'd normally do #3, but with many people piping things to git-am, I'm not sure > > if it's the safest choice. > > > > Exibit a: https://lwn.net/Articles/874546/ > > +Cc: git@vger > > IMHO, defense for this belongs in git-am (which already checks > things like whitespace). I agree, but even if that is implemented in git, we'll still probably want to catch this on the b4 side of things until everyone uses the git client where that's handled natively. -K
