On 10/31/21 2:07 PM, Junio C Hamano wrote: > Eli Schwartz <eschwartz@xxxxxxxxxxxxx> writes: > >> The %(describe) placeholder by default, like `git describe`, only >> supports annotated tags. However, some people do use lightweight tags >> for releases, and would like to describe those anyway. The command line >> tool has an option to support this. >> >> Teach the placeholder to support this as well. >> >> Signed-off-by: Eli Schwartz <eschwartz@xxxxxxxxxxxxx> >> --- >> >> I use lowercase "bool" here not "boolean-value" because I don't see >> utility in the word "value" here. > > Such a comment is much more useful if it is sent as a review to the > patch that touches the same area as your patch does, namely, > > https://lore.kernel.org/git/984b6d687a2e779c775de6ea80536afe6ecc0aaf.1635438124.git.gitgitgadget@xxxxxxxxx/ > > not here. Indeed, done. (I had to unexpectedly step away for a bit after sending my updated series.) -- Eli Schwartz Arch Linux Bug Wrangler and Trusted User
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
