"Johannes Schindelin via GitGitGadget" <gitgitgadget@xxxxxxxxx>
writes:
> @@ -12,9 +15,19 @@ int cmd__genzeros(int argc, const char **argv)
>
> count = argc > 1 ? strtoimax(argv[1], NULL, 0) : -1;
>
> - while (count < 0 || count--) {
> - if (putchar(0) == EOF)
> + /* Writing out individual NUL bytes is slow... */
> + while (count < 0)
> + if (write(1, zeros, ARRAY_SIZE(zeros)) < 0)
> return -1;
> +
> + while (count > 0) {
> + n = write(1, zeros, count < ARRAY_SIZE(zeros) ?
> + count : ARRAY_SIZE(zeros));
> +
> + if (n < 0)
> + return -1;
> +
> + count -= n;
> }
>
> return 0;
This round looks OK to me.
