Junio C Hamano <gitster@xxxxxxxxx> wrote: > Eric Wong <e@xxxxxxxxx> writes: > > > v2 changes: > > * s/GIT_FSYNC/GIT_TEST_FSYNC/ > > * disable fsync by default for tests, reduces setup for newcomers > > * fix style nit noted by Eric Sunshine > > https://github.com/git/git/runs/4043532265?check_suite_focus=true#step:5:70 Fwiw, I couldn't view that (not sure if it's from lack of JS or lack of GH account). Either way it's accessibility problem. > Seems to be dying in "git svn" tests somehow. Easy repro+fix, though. I only tested my final patch with NO_SVN_TESTS :x Can you squash this in or do you want a reroll? diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm index df5a87a151..6ce2e283c8 100644 --- a/perl/Git/SVN.pm +++ b/perl/Git/SVN.pm @@ -2274,7 +2274,7 @@ sub use_fsync { if (!defined($_use_fsync)) { my $x = $ENV{GIT_TEST_FSYNC}; if (defined $x) { - my $v = command_oneline('git', '-c', "test.fsync=$x", + my $v = command_oneline('-c', "test.fsync=$x", qw(config --type=bool test.fsync)); $_use_fsync = defined($v) ? ($v eq "true\n") : 1; }
