"Ivan Frade via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
> diff --git a/pkt-line.c b/pkt-line.c
> index 2dc8ac274bd..06013d2a54a 100644
> --- a/pkt-line.c
> +++ b/pkt-line.c
> @@ -370,6 +370,31 @@ int packet_length(const char lenbuf_hex[4])
> return (val < 0) ? val : (val << 8) | hex2chr(lenbuf_hex + 2);
> }
>
> +static char *find_packfile_uri_path(const char *buffer)
> +{
> + const char *URI_MARK = "://";
> + char *path;
> + int len;
> +
> + /* First char is sideband mark */
> + buffer += 1;
> +
> + len = strspn(buffer, "0123456789abcdefABCDEF");
> + if (!(len == 40 || len == 64) || buffer[len] != ' ')
> + return NULL; /* required "<hash>SP" not seen */
People may have comments on hardcoded 40/64 here and offer a better
way to write it ;-)
> + path = strstr(buffer + len + 1, URI_MARK);
> + if (!path)
> + return NULL;
> +
> + path = strchr(path + strlen(URI_MARK), '/');
> + if (!path || !*(path + 1))
> + return NULL;
> +
> + /* position after '/' */
> + return ++path;
> +}
Other than that, the patch this round looks quite clean.
Nicely done.
Thanks, will queue.
