Re: [PATCH v2 3/3] pretty: add abbrev option to %(describe)

[Eric Sunshine <sunshine@xxxxxxxxxxxxxx>]

On Tue, Oct 26, 2021 at 8:07 AM Đoàn Trần Công Danh
<congdanhqx@xxxxxxxxx> wrote:
> On 2021-10-25 21:34:52-0400, Eli Schwartz <eschwartz@xxxxxxxxxxxxx> wrote:
> > +                                     if (!arglen)
> > +                                             return 0;
> > +                                     char* endptr;
>
> Other than the question pointed out by Eric,
>
> with DEVELOPER=1, -Werror=declaration-after-statement
> We'll need this change squashed in:
>
> +                                       char* endptr;
>                                         if (!arglen)
>                                                 return 0;
> -                                       char* endptr;

This highlights a style nit, as well; should be:

    char *endptr;