Hi Bagas, On Mon, 25 Oct 2021 at 11:19, Bagas Sanjaya <bagasdotme@xxxxxxxxx> wrote: > > On 25/10/21 00.09, Martin Ågren wrote: > > Martin Ågren (3): > > git-multi-pack-index.txt: change "folder" to "directory" > > gitignore.txt: change "folder" to "directory" > > gitweb.txt: change "folder" to "directory" > > > > The same logical change over three patches, why aren't they be squashed > into single commit? Old habit, I guess. :) I tend to find that having multiple patches aids reviewing. Within reason, obviously. Reviewers don't have to go "I agree with everything except that particular hunk", but can just say "I agree with everything except patch two", making tracking things a bit easier. Similarly, if the patches are all independent (albeit being about the same topic) and it comes up that a particular patch is not such a good idea after all because reasons, Junio could just decide to apply a subset and leave the rest. In this case, the commit message of the third patch assumes that the first two have already been applied, so they're not completely independent, but that's about the only interdependency there is in these. I'm happy to go either way. Martin
