On Thu, Oct 21, 2021 at 09:57:54PM +0200, Ævar Arnfjörð Bjarmason wrote: > This removes the dependency of our built *.sh on $(GIT_VERSION), which > as noted in 2/6 looks to have been the intention back in 2012, but > didn't happen then. > > The rest of the series removes more dead code related to our > $(SCRIPT_DEFINES), some of it it not used or needed for 5-15ish years. > > Ævar Arnfjörð Bjarmason (6): > Makefile: move git-SCRIPT-DEFINES adjacent to $(SCRIPT_DEFINES) > Makefile: remove $(GIT_VERSION) from $(SCRIPT_DEFINES) > Makefile: remove $(NO_CURL) from $(SCRIPT_DEFINES) > git-instaweb: unconditionally assume that gitweb is mod_perl capable > git-sh-setup: remove unused sane_egrep() function > git-sh-setup: remove "sane_grep", it's not needed anymore The first five all look obviously correct to me. The 6th also looks fine, but I don't have a strong opinion on the filter-branch thing either way. -Peff
