Re: [PATCH v4 8/8] progress.c: add & assert a "global_progress" variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 25.10.21 um 13:25 schrieb Ævar Arnfjörð Bjarmason:
> Once we have a
> global current progress object we'll be able to update that object via
> SIGALRM, this will cover cases where we're busy, but either haven't
> invoked our first display_progress() yet, or the time between
> display_progress() is too long. See [3] for early code to do that.

This can't be a goal. You cannot do serious stuff in a signal handler.
Don't proliferate complicated signal handlers.

On top of that, our SIGALRM handler on Windows runs in its own thread
and can't do more than set a volatile sigatomic_t (and even that is
undefined behavior, strictly speaking).

-- Hannes



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux