Hi Junio, On Thu, 21 Oct 2021, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > > > 2. The SANE_TEXT_GREP added in 71b401032b9 (sane_grep: pass "-a" if > > grep accepts it, 2016-03-08) isn't needed either, none of these grep > > uses deal with binary data. > > For all other users, I think the above applies well, but the one in > filter-branch deals with end-user contents, so we cannot say > "contents of the tag cannot be binary". > > Not that I care about filter-branch too deeply ;-) You probably meant that you do not care about filter-branch too deeply? ;-) FWIW neither do I. Recently, I had the need for some large-scale rewriting, and I used this as an excuse to learn me some `git-repo-filter`. I was pleasantly surprised how easy it is to use, and how fast it works. So yeah, I don't care about `git filter-branch` too deeply, either ;-) Ciao, Dscho
