Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > In addition the xstrfmt() to get the "full_ref" in the same commit > isn't needed, we can use the "REFNAME_ALLOW_ONELEVEL" flag to > check_refname_format() instead. Reading the code of check_refname_format(), I do not think one-level is the only thing that the prefixing of refs/heads/ is defeating, and more importantly, I'd expect that this will block later changes like enforcing "HEAD might be OK in onelevel because we want to keep .git/HEAD working, but we do not like refs/heads/HEAD" at this level to enhance usability from happening. Making the function file-local static is a good thing to do, though.