On 21/10/2021 04:42, Han Xin wrote: >>> +static void write_stream_blob(unsigned nr, unsigned long size) >> Can we use size_t for the `size`, and possibly `nr`, to improve >> compatibility with Windows systems where unsigned long is only 32 bits? >> >> There has been some work in the past on providing large file support on >> Windows, which requires numerous long -> size_t changes. >> >> Philip > Thanks for your review. I'm not sure if I should do this change in this patch, > it will also change the type defined in `unpack_one()`,`unpack_non_delta_entry`, > `write_object()` and many others. > I was mainly raising the issue regarding the 4GB (sometime 2GB) limitations on Windows which has been a problem for many years. I had been thinking of not changing the `nr` (number of objects limit) as 2G objects is hopefully already sufficient, even for thargest of repos (though IIUC their index file size did break the 32bit size limit). Staying with the existing types won't make the situation any worse, so from that perspective the change isn't needed. -- Philip
