On Wed, Oct 20, 2021 at 02:27:30PM +0200, Johannes Schindelin wrote: > Hi Peff, > > On Fri, 8 Oct 2021, Jeff King wrote: > > > On Fri, Oct 08, 2021 at 09:51:33AM +0200, Johannes Schindelin wrote: > > > > > FWIW I have set up an Azure Pipeline to keep Git for Windows' `main` > > > branch covered by Coverity: > > > > > > https://dev.azure.com/git-for-windows/git/_build?definitionId=35 > > > > > > It essentially calls into this scripted code: > > > https://github.com/git-for-windows/build-extra/blob/4676f286a1ec830a5038b32400808a353dc6c48d/please.sh#L1820-L1915 > > > > Do you have any objection to adding something like the Action I showed > > eariler? It would do nothing in git-for-windows/git unless you set up > > the right environment, so there shouldn't be any downside. > > No objection. I'd just ask to use `${{github.repository}}` instead of > hard-coding `peff/git`, and to really not run the workflow unless > configured. So something like this: > > [...] > > I am very much in favor of having this in git/git. Do you want to provide > the commit message, or do you want me to shepher this? This all looks good to me. FWIW, I was planning on picking this up myself, but I'm happy to have been beaten to it ;). The only thing missing is having a project for git.git set up on Coverity's website. I'd be happy to look into that if you wanted to polish this up and submit it. We should be able to proceed independently, since this will all be a noop without setting the various Coverity secrets inside of git/git. Thanks, Taylor
