On Tue, Oct 19, 2021 at 02:31:34PM +0200, Ævar Arnfjörð Bjarmason wrote: > Fix a regression in 8c328561332 (blame: document --color-* options, > 2021-10-08), which added an extra newline before the "+" syntax. Thanks, this looks like an obviously correct fix. I think asciidoc's pickiness around "+" has bitten us before. Asciidoctor is more lenient here, and the rendered result looks the same before and after your patch, but we should definitely make it look good in both. > The "Documentation/doc-diff HEAD~ HEAD" output with this applied is: I just want to call this out not only as a good way to review this patch, but a great way in general to review any patches which touch documentation. Running: doc-diff 8c328561332^ 8c328561332 shows the original problem pretty clearly. > Documentation/config/color.txt | 2 -- > 1 file changed, 2 deletions(-) Patch looks good. There's a small typo in the subject: > Subject: [PATCH] git config doc: fix recent ASCIIDOC formatting regresison s/regresison/regression/ -Peff
