[PATCH 3/9] Remove unnecessary debugging from builtin-fetch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The older git-fetch client did not produce all of this debugging
information to stdout.  Most end-users and Porcelain (e.g. StGIT,
git-gui, qgit) do not want to see these low-level details on the
console so they should be removed.

Signed-off-by: Shawn O. Pearce <spearce@xxxxxxxxxxx>
---
 builtin-fetch-pack.c |    2 --
 builtin-fetch.c      |    9 ---------
 2 files changed, 0 insertions(+), 11 deletions(-)

diff --git a/builtin-fetch-pack.c b/builtin-fetch-pack.c
index 3b217d9..e77cd26 100644
--- a/builtin-fetch-pack.c
+++ b/builtin-fetch-pack.c
@@ -767,8 +767,6 @@ struct ref *fetch_pack(const char *dest, int nr_heads, char **heads)
 			st.st_mtime = 0;
 	}
 
-	printf("connect to %s\n", dest);
-
 	pid = git_connect(fd, (char *)dest, uploadpack,
                           verbose ? CONNECT_VERBOSE : 0);
 	if (pid < 0)
diff --git a/builtin-fetch.c b/builtin-fetch.c
index 016c6e4..33b740c 100644
--- a/builtin-fetch.c
+++ b/builtin-fetch.c
@@ -370,15 +370,6 @@ static int do_fetch(struct transport *transport,
 	for (rm = ref_map; rm; rm = rm->next) {
 		if (rm->peer_ref)
 			read_ref(rm->peer_ref->name, rm->peer_ref->old_sha1);
-
-		printf("%s : %s\n", rm->name, rm->peer_ref ? rm->peer_ref->name : NULL);
-		printf("  < %s\n", sha1_to_hex(rm->old_sha1));
-		if (rm->peer_ref)
-			printf("  > %s\n", sha1_to_hex(rm->peer_ref->old_sha1));
-		if (!rm->peer_ref ||
-		    hashcmp(rm->old_sha1, rm->peer_ref->old_sha1)) {
-			printf("%s needs update.\n", rm->name);
-		}
 	}
 
 	if (fetch_refs(transport, ref_map)) {
-- 
1.5.3.1.69.g0771

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux