On 17/10/2021 11:06, Ævar Arnfjörð Bjarmason wrote: > > On Sat, Oct 16 2021, Junio C Hamano wrote: > >> Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> writes: >> >>> Hi Junio, >>> >>> Tonight's build of 'seen' failed for me (on Linux and Cygwin): >> >> Yes, I saw the same with the report at >> >> https://lore.kernel.org/git/xmqqh7djba6e.fsf@gitster.g/ >> >> the ball is in Ævar's court. Oops! Sorry for the duplicate report. I'm obviously not reading the list closely enough. :( > As an aside is that "uninitialized" found by any tool/compiler? I didn't > trigger it with anything I tried. I only get the warning with gcc (v9.3.0 on Linux, and v11.2.0 on Cygwin). [clang version 10.0.0-4ubuntu1 on Linux and clang version 8.0.1 on Cygwin do not issue any warnings] Also, this particular warning depends on the level of optimization used with the command. I build with the default 'CFLAGS = -g -O2 -Wall' and with 'DEVELOPER=1'. On Linux: $ make V=1 refs/files-backend.o GIT_VERSION = 2.33.1.1033.g957ac05270 cc -o refs/files-backend.o -c -MF refs/.depend/files-backend.o.d -MQ refs/files-backend.o -MMD -MP -Werror -Wall -pedantic -Wpedantic -Wdeclaration-after-statement -Wformat-security -Wold-style-definition -Woverflow -Wpointer-arith -Wstrict-prototypes -Wunused -Wvla -fno-common -Wextra -Wmissing-prototypes -Wno-empty-body -Wno-missing-field-initializers -Wno-sign-compare -Wno-unused-parameter -g -O2 -Wall -I. -DHAVE_SYSINFO -DGIT_HOST_CPU="\"x86_64\"" -DHAVE_ALLOCA_H -DUSE_CURL_FOR_IMAP_SEND -DSUPPORTS_SIMPLE_IPC -DSHA1_DC -DSHA1DC_NO_STANDARD_INCLUDES -DSHA1DC_INIT_SAFE_HASH_DEFAULT=0 -DSHA1DC_CUSTOM_INCLUDE_SHA1_C="\"cache.h\"" -DSHA1DC_CUSTOM_INCLUDE_UBC_CHECK_C="\"git-compat-util.h\"" -DSHA256_BLK -DHAVE_PATHS_H -DHAVE_DEV_TTY -DHAVE_CLOCK_GETTIME -DHAVE_CLOCK_MONOTONIC -DHAVE_SYNC_FILE_RANGE -DHAVE_GETDELIM '-DPROCFS_EXECUTABLE_PATH="/proc/self/exe"' -DFREAD_READS_DIRECTORIES -DNO_STRLCPY -DSHELL_PATH='"/bin/sh"' -DPAGER_ENV='"LESS=FRX LV=-c"' refs/files-backend.c refs/files-backend.c: In function ‘files_reflog_expire’: refs/files-backend.c:3212:11: error: ‘type’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 3212 | !(type & REF_ISSYMREF) && | ~~~~~~^~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make: *** [Makefile:2555: refs/files-backend.o] Error 1 $ ATB, Ramsay Jones
