Michele Ballabio <barra_cuda@xxxxxxxxxxxx> wrote:
> Most of these changes were suggested by Shawn Pearce in an answer
> to Johannes Schindelin.
>
> Some strings for the blame module were added too.
Many thanks. Applied to master. Will push shortly.
> I added the trailing space to the next string:
>
> + $tooltip_t insert end [mc "In File:"] section_header
> + $tooltip_t insert end " $file\n"
>
> instead of appending it. It just seemed easier to read. Do you
> prefer using [append ...] here too?
I went with [append ...] as I was afraid the section_header might
apply different width to the " " than the next line which does not
use a formatting control tag. It may not matter right now but I
don't want to be surprised by it in the future if section_header
changes. I tweaked the patch by hand locally, so no need to resend.
> @@ -489,8 +489,8 @@ method _exec_blame {cur_w cur_d options cur_s} {
> set blame_lines 0
>
> $status start \
> - "Loading$cur_s annotations..." \
> - {lines annotated}
> + "$cur_s" \
> + [mc "lines annotated"]
> }
Also just for your information the $cur_s argument did not need to
be double quoted here. I dropped the "" around it when I applied
the patch. I don't know if there is a performance difference,
but even if there was one it wouldn't matter as this particular
line is run so infrequently it just isn't an issue. Style wise I
simply prefer to not quote something unless it really needs it.
--
Shawn.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
