On 2021.10.08 14:08, Jonathan Tan wrote: > Thanks everyone for your reviews. Here's an updated patch set, including > Carlo's fixup squashed. > > Jonathan Tan (7): > refs: plumb repo into ref stores > refs: teach arbitrary repo support to iterators > refs: peeling non-the_repository iterators is BUG > merge-{ort,recursive}: remove add_submodule_odb() > object-file: only register submodule ODB if needed > submodule: pass repo to check_has_commit() > submodule: trace adding submodule ODB as alternate This looks good to me. All my concerns from v3 have been addressed, so: Reviewed-by: Josh Steadmon <steadmon@xxxxxxxxxx>