> > +void strbuf_add_unique_abbrev(struct strbuf *sb, const struct object_id *oid, > > + int abbrev_len) > > +{ > > + strbuf_repo_add_unique_abbrev(sb, the_repository, oid, abbrev_len); > > +} > > + > > Should strbuf_add_unique_abbrev() be inlined and moved to the header? I felt that it wasn't worth writing '#include "repository.h"' in strbuf.h just so that I could inline it. (The function signature just uses "struct repository" opaquely so "struct repository;" is fine, but the function definition itself will require full information about the_repository so we would need to include the file.)