Re: [PATCH 2/2] git-commit: Add --fast option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 12, 2007 at 10:37:41PM -0400, Jeff King wrote:
> On Thu, Sep 13, 2007 at 03:47:18AM +0400, Dmitry V. Levin wrote:
> 
> > @@ -54,6 +54,7 @@ run_status () {
> >  	else
> >  		color=--nocolor
> >  	fi
> > +	test -z "$fast" || return 0
> >  	git runstatus ${color} \
> >  		${verbose:+--verbose} \
> >  		${amend:+--amend} \
> 
> Wouldn't this make more sense at the _top_ of the runstatus function
> (since everything else it does is preparation for running "git
> runstatus"?).

The run_status() also defines GIT_INDEX_FILE environment variable which
may affect other git commands like git-write-tree.

> Also, is the builtin git-commit going to be merged soon? Should this
> effort be better spent on that branch?

I need this new option for my work now, I have to backport it to
previous stable branch, because git-runstatus needs too much memory and
runs too long in some cases.  Even worse, git-runstatus segfaults in one
case I'm going to debug yet.

The --fast option should be easy to port forward to builtin git-commit
anyway.


-- 
ldv

Attachment: pgpK8bFj0prFB.pgp
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux