Differences from V5: Addresses original Ævar's patch: - Effectively including all combined options, which ends up adding --dump-aliases and --identity. - Manually excluded --h and --git-completion-helper. This is consistent with "git format-patch --git-completion-helper". - Completely dropped sorting, because it seems the current git subcommands don't really care about it (I verified "git format-patch" and "git apply" only). As mentioned earlier, the following issue remains open: > "The following options exist in GetOptions but not in the current > usage string: > > --no-signed-off-cc --sender --signed-off-cc" I wouldn't mind adding a fourth patch to this series that fixes the current usage, just let me know which wording you'd like me to add. Finally, I will note that I haven't touched the third patch of this series (git-send-email.txt) because it is not obvious to me which direction we're taking. My understanding is that Junio prefers to leave things as is, but let me know if I should change it to e.g. Carlos' or Bagas' version. Thiago Perrotta (3): send-email: terminate --git-completion-helper with LF send-email: programmatically generate bash completions send-email docs: add format-patch options Documentation/git-send-email.txt | 6 ++-- contrib/completion/git-completion.bash | 11 +------ git-send-email.perl | 43 +++++++++++++++++++------- t/t9902-completion.sh | 3 ++ 4 files changed, 40 insertions(+), 23 deletions(-) -- 2.33.0
