Re: [PATCH] git-gui: Font chooser to handle a large number of font families

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Simon Sasburg <simon.sasburg@xxxxxxxxx> wrote:
> On 9/12/07, Shawn O. Pearce <spearce@xxxxxxxxxxx> wrote:
> > This is now also available in my `pu` branch on repo.or.cz.
> > Does it fix your problem Simon?  Any comments?
> 
> Unfortunately it seems to have focus problems. When the font dialog is
> opened none of the controls in it respond to any clicks, while the
> option dialog still responds to clicks (i can open the font dialog
> multiple times even).

Whoops.  I just played with this over VNC/X11 and I think the
following patch applied on top fixes the issue; its now in pu.

diff --git a/lib/choose_font.tcl b/lib/choose_font.tcl
index f7e87ff..2239f70 100644
--- a/lib/choose_font.tcl
+++ b/lib/choose_font.tcl
@@ -54,6 +54,7 @@ constructor pick {path title a_family a_size} {
 		-anchor w
 	set w_family $w.inner.family.v
 	text $w_family \
+		-background white \
 		-borderwidth 1 \
 		-relief sunken \
 		-cursor $::cursor_ptr \
@@ -89,6 +90,7 @@ constructor pick {path title a_family a_size} {
 		-anchor w
 	set w_example $w.example.t
 	text $w_example \
+		-background white \
 		-borderwidth 1 \
 		-relief sunken \
 		-height 3 \
@@ -120,7 +122,10 @@ constructor pick {path title a_family a_size} {
 	trace add variable @f_size write [cb _update]
 	bind $w <Key-Escape> [list destroy $w]
 	bind $w <Key-Return> [cb _select]\;break
-	grab $w
+	bind $w <Visibility> "
+		grab $w
+		focus $w
+	"
 	tkwait window $w
 }
 

-- 
Shawn.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux