On Mon, Oct 4, 2021 at 9:36 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > Carlo Marcelo Arenas Belón <carenas@xxxxxxxxx> writes: > > diff --git a/compat/terminal.c b/compat/terminal.c > > index 43b73ddc75..1fadbfd6b6 100644 > > --- a/compat/terminal.c > > +++ b/compat/terminal.c > > @@ -8,7 +8,7 @@ > > > > #if defined(HAVE_DEV_TTY) || defined(GIT_WINDOWS_NATIVE) > > > > -static void restore_term(void); > > +void restore_term(void); > > Curious why you need this because (1) we do not have the same for > save_term() here, and (2) we include compat/terminal.h where these > two are declared next to each other. It is in preparation for the next patch where we will call these newly public functions from editor.c I'll be reusing restore_term(), while save_term() is new, hence why only one had this change. Carlo
