On Sat, Oct 2, 2021 at 11:19 AM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > Follow-up the change in 459b8d22e54 (tests: do not borrow from COPYING > and README from the real source, 2015-02-15) by not shipping a full > copy of older versions of the top-level "COPYING" and "README" files. > > The tests that use them just need the small blurb at the top of > "COPYING" as test data, or mock data that's dissimilar. Let's provide > that with a "COPYING_test_data" function instead. I had to read this patch a couple of times before I understood what was going on. Your change is a definite improvement, but if the actual contents don't matter that much, maybe something like "lorum ipsum" would be even better. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
