On Mon, Oct 04 2021, Elijah Newren wrote: > On Sun, Oct 3, 2021 at 5:46 PM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: >> >> Plug memory leaks in various built-ins that were missing >> unpack_trees_options_release() calls. In an earlier commit these >> functions were all made to use the "UNPACK_TREES_OPTIONS_INIT" macro, >> now let's have the ones that didn't clean up their memory do so. > > This commit message doesn't say anything about what was leaking. You > should really bring up that it was the dir_clear() you added to > unpack_trees_options_release() earlier in the series that is important > here (or at least that's what I presume is the important fix). *nod*, willdo. > Looks good to me; thanks for catching and fixing these leaks.
