On Fri, Oct 1, 2021 at 6:06 AM Phillip Wood via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > The reset bit should only be set if flags contains RESET_HEAD_HARD. > The test for `!deatch_head` dates back to the original implementation s/deatch_head/detach_head/ > of reset_head() in ac7f467fef ("builtin/rebase: support running "git > rebase <upstream>"", 2018-08-07) and was correct until e65123a71d > ("builtin rebase: support `git rebase <upstream> <switch-to>`", > 2018-09-04) started using reset_head() to checkout <switch-to> when > fast-forwarding. > > Signed-off-by: Phillip Wood <phillip.wood@xxxxxxxxxxxxx>