"Phillip Wood via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > From: Phillip Wood <phillip.wood@xxxxxxxxxxxxx> > > This function already takes a confusingly large number of parameters > some of which are optional or not always required. The following > commits will add a couple more parameters so change it to take a > struct of options first. Would all the members in the struct always be used by the function? If not, such a change will *not* solve the "confusingly ... required" problem at all. I am not necessarily against a change to consolidate a bag of parameters into a pointer to a struct. I am against a change that is justified with a benefit that the change does not bring to us. Thanks.
