On Tue, Sep 28, 2021 at 02:56:03PM +0200, Ævar Arnfjörð Bjarmason wrote: > The git_config_key_is_valid() function got left behind in a > refactoring in a9bcf6586d1 (alias: use the early config machinery to > expand aliases, 2017-06-14), > > It previously had two users when it was added in 9e9de18f1ad (config: > silence warnings for command names with invalid keys, 2015-08-24), and > after 6a1e1bc0a15 (pager: use callbacks instead of configset, > 2016-09-12) only one remained. > > By removing it we can get rid of the "quiet" branches in this > function, as well as cases where "store_key" is NULL, for which there > are no other users. Yeah, the patch here is trivially correct. The greater question is whether we're likely to need this quiet parameter again. I kind of doubt it given the history, so this seems like a sensible cleanup. > Out of the 5 callers of git_config_parse_key() only one needs to pass > a non-NULL "size_t *baselen_", so we could remove the third parameter > from the public interface. I did not find that potential > simplification to be worthwhile. Yeah, I think stopping here is good for now. -Peff
