On Tue, Sep 28, 2021 at 2:16 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > > On Tue, Sep 28, 2021 at 1:08 PM Matheus Tavares > <matheus.bernardino@xxxxxx> wrote: > > In some circumstances, "git grep --textconv --recurse-submodules" > > ignores the textconv attributes from the submodules and erroneuosly > > apply the attributes defined in the superproject on the submodules' > > files. The textconv cache is also saved on the superproject, even for > > submodule objects. > > s/erroneuosly/erroneously/ > > Also, perhaps: s/apply/applies/ > > > Signed-off-by: Matheus Tavares <matheus.bernardino@xxxxxx> > > diff --git a/t/t7814-grep-recurse-submodules.sh b/t/t7814-grep-recurse-submodules.sh > > @@ -441,4 +441,107 @@ test_expect_success 'grep --recurse-submodules with --cached ignores worktree mo > > +test_expect_failure 'grep --textconv corectly reads submodule .gitattributes' ' > > Here and in remaining newly added tests: s/corectly/correctly/ > > > +test_expect_failure 'grep saves textconv cache in the appropriated repository' ' > > s/appropriated/appropriate/ Oops, I should have been more careful with the writing. Thanks for catching those!
