On Fri, Aug 27, 2021 at 8:53 PM Mugdha Pattnaik via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > > From: mugdha <mugdhapattnaik@xxxxxxxxx> > > Currently, running 'git submodule deinit' on repos where the > submodule's '.git' is a directory, aborts with a message that is not > exactly user friendly. Let's change this to instead warn the user > to rerun the command with '--force'. It seems to me that this patch fell into the cracks. Or did I miss something? > This internally calls 'absorb_git_dir_into_superproject()', which > moves the git dir into the superproject and replaces it with > a '.git' file. The rest of the deinit function can operate as it > already does with new-style submodules. > > We also edit a test case such that it matches the new behaviour of > deinit. > > Suggested-by: Atharva Raykar <raykar.ath@xxxxxxxxx> > Signed-off-by: Mugdha Pattnaik <mugdhapattnaik@xxxxxxxxx>
