Re: [PATCH 01-13/13] builtin-fetch series.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Very impressed by the entire series and mildly amused.  Thanks.

A few C++ style comments sprinkled here and there were eyesore,
but I'll hopefully survive.

You seem to have a stray printf("connect to ...\n"); as the
command is expected to show the list of refs it fetched from the
other side, this may interfere with what the caller wants to do.

The changes to t5515 test vectors worry me quite a lot, as the
distinction between not-for-merge and others is what decides the
outcome of a pull, but I didn't look very closely.

Unfortunately I do not have enough time for a full review during
the workday evenings.  Hopefully will take a deper look on my
next git day.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux