> No callers pass in anything but "0" here. Likewise to our sibling > functions. Note that some of them ferry along the flag, but none of > their callers pass anything but "0" either. > > Nor is anybody likely to change that. Callers which really want to see > all of the raw refs use for_each_rawref(). And anybody interested in > iterating a subset of the refs will likely be happy to use the > now-default behavior of showing broken refs, but omitting dangling > symlinks. > > So we can get rid of this whole feature. > > Signed-off-by: Jeff King <peff@xxxxxxxx> All the patches look good. Reviewed-by: Jonathan Tan <jonathantanmy@xxxxxxxxxx> As you have mentioned before, this clashes with my series [1]. But since I'll need to update my series anyway to reinclude the DO_FOR_EACH_INCLUDE_BROKEN flag, the obvious thing is for me to rebase mine on top of yours so that yours can go in first, so I don't mind doing that. [1] https://lore.kernel.org/git/cover.1632242495.git.jonathantanmy@xxxxxxxxxx/
