On Fri, Sep 24, 2021 at 8:15 PM Bagas Sanjaya <bagasdotme@xxxxxxxxx> wrote: > > On 25/09/21 06.53, Neeraj Singh via GitGitGadget wrote: > > At the end of the entire transaction when unplugging bulk checkin we: > > 1. Issue an fsync against a dummy file to flush the hardware writeback > > cache, which should by now have processed the tmp-objdir writes. > > 2. Rename all of the tmp-objdir files to their final names. > > 3. When updating the index and/or refs, we assume that Git will issue > > another fsync internal to that operation. This is not the case today, > > but may be a good extension to those components. > > The 'we' can be stripped because only point 1 and 2 that are > subject-inferred, so that subject needs to be explicitly mentioned, like: > > ``` > At the end of ... <snip>.: > 1. We issue an fsync ... <snip>. > 2. We rename ... <snip>. > 3. When ... <snip>, we assume <snip>. (stays same) > ``` I'll fix this in the github PR so that it will ride along with any other re-roll. Thanks, Neeraj
